Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle URLs with escaped characters #149

Merged
merged 2 commits into from
Nov 24, 2017
Merged

Handle URLs with escaped characters #149

merged 2 commits into from
Nov 24, 2017

Conversation

ethantkoenig
Copy link
Contributor

Allow characters such as / inside route parameters when they are properly escaped. See go-gitea/gitea#2869 (comment)

cc @svarlamov

@ethantkoenig ethantkoenig mentioned this pull request Nov 23, 2017
Closed
@unknwon
Copy link
Contributor

unknwon commented Nov 23, 2017

Hi, CI is failing from Go 1.5-1.7, can you fix that?

@lafriks
Copy link

lafriks commented Nov 23, 2017

@ethantkoenig you can use something like there for PathUnescape:
https://github.com/labstack/echo/blob/master/util_go17.go
https://github.com/labstack/echo/blob/master/util_go18.go

@ethantkoenig
Copy link
Contributor Author

Fixed

@unknwon
Copy link
Contributor

unknwon commented Nov 24, 2017

Thank you!

@unknwon unknwon merged commit dcfa989 into go-macaron:master Nov 24, 2017
@unknwon
Copy link
Contributor

unknwon commented Nov 24, 2017

Tag added, you can now re-pull to get the latest version.

@ethantkoenig ethantkoenig deleted the fix/escaped_paths branch January 17, 2018 06:37
@ethantkoenig ethantkoenig mentioned this pull request Jan 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ethantkoenig @unknwon @lafriks