fix(GetForToken): added support for pointer to interface{} #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reflect-based switch doesn't work when the value passed is *any:
the resulting indirection is typed as reflect.Interface and not
the actual underlying type.
* added more stringent checking on nil values (i.e. covers
interface{}(nil)
* contributes: go-swagger/go-swagger#1898 (pointers to content of a
x-... swagger extension)
Signed-off-by: Frederic BIDON <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #16 +/- ##
==========================================
+ Coverage 69.13% 70.50% +1.36%
==========================================
Files 1 1
Lines 324 339 +15
==========================================
+ Hits 224 239 +15
Misses 75 75
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fredbi
added a commit
to fredbi/analysis
that referenced
this pull request
Dec 21, 2023
This PR allows for reusing schemas stored in x-... extensions of the spec, via json pointers. We have seen some specs using such extensions to create "alternate definitions". The spec flattening canonicalizes such schemas by reintroducing them as #/definitions, so they can be consumed by codegen. * requires: go-openapi/jsonpointer#16 * contributes: go-swagger/go-swagger#1898 Signed-off-by: Frederic BIDON <[email protected]>
fredbi
added a commit
to fredbi/analysis
that referenced
this pull request
Dec 21, 2023
This PR allows for reusing schemas stored in x-... extensions of the spec, via json pointers. We have seen some specs using such extensions to create "alternate definitions". The spec flattening canonicalizes such schemas by reintroducing them as #/definitions, so they can be consumed by codegen. * requires: go-openapi/jsonpointer#16 * contributes: go-swagger/go-swagger#1898 Signed-off-by: Frederic BIDON <[email protected]>
fredbi
added a commit
to fredbi/analysis
that referenced
this pull request
Dec 21, 2023
This PR allows for reusing schemas stored in x-... extensions of the spec, via json pointers. We have seen some specs using such extensions to create "alternate definitions". The spec flattening canonicalizes such schemas by reintroducing them as #/definitions, so they can be consumed by codegen. * requires: go-openapi/jsonpointer#16 * contributes: go-swagger/go-swagger#1898 Signed-off-by: Frederic BIDON <[email protected]>
youyuanwu
approved these changes
Dec 21, 2023
fredbi
added a commit
to fredbi/analysis
that referenced
this pull request
Dec 21, 2023
This PR allows for reusing schemas stored in x-... extensions of the spec, via json pointers. We have seen some specs using such extensions to create "alternate definitions". The spec flattening canonicalizes such schemas by reintroducing them as #/definitions, so they can be consumed by codegen. * requires: go-openapi/jsonpointer#16 * contributes: go-swagger/go-swagger#1898 Signed-off-by: Frederic BIDON <[email protected]>
fredbi
added a commit
to go-openapi/analysis
that referenced
this pull request
Dec 22, 2023
This PR allows for reusing schemas stored in x-... extensions of the spec, via json pointers. We have seen some specs using such extensions to create "alternate definitions". The spec flattening canonicalizes such schemas by reintroducing them as #/definitions, so they can be consumed by codegen. * requires: go-openapi/jsonpointer#16 * contributes: go-swagger/go-swagger#1898 Signed-off-by: Frederic BIDON <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reflect-based switch doesn't work when the value passed is *any: the resulting indirection is typed as reflect.Interface and not the actual underlying type.