Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run test on GitHub Actions for three platforms #35

Merged
merged 1 commit into from
Oct 9, 2021

Conversation

koron
Copy link
Contributor

@koron koron commented Feb 4, 2021

This PR adds GitHub Actions workflow to run test with three OS: Linux (ubuntu), macOS, and Windows.

go-swagger/go-swagger#2492 (comment) might be prevented if there are tests on multiple platform.

So I created it using GitHub Actions.


This PR is branched from v0.20.0 for GHA failes on Windows only.
You can see example run here

@koron koron force-pushed the multiplatform-test-gha branch from b9d9d20 to f35a10c Compare February 4, 2021 05:22
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #35 (f35a10c) into master (35cd441) will decrease coverage by 3.46%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
- Coverage   82.53%   79.06%   -3.47%     
==========================================
  Files           3        3              
  Lines         166      172       +6     
==========================================
- Hits          137      136       -1     
- Misses         14       21       +7     
  Partials       15       15              
Impacted Files Coverage Δ
loaders.go 83.72% <0.00%> (-16.28%) ⬇️
options.go 100.00% <0.00%> (ø)
spec.go 72.89% <0.00%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35cd441...f35a10c. Read the comment docs.

@fredbi
Copy link
Member

fredbi commented Feb 4, 2021

@koron thanks. You should know that at the moment, the full test suite is broken on windows (even though ordinary cases work).
This is due to github.com/go-openapi/spec#97 which I am trying to deal with at the moment (issue with remote circular $ref forming an invalid URI).
Getting to know github actions could be nice, however. I've tried to set up appveyor for macOS but the setting was a mess.

@casualjim casualjim merged commit a71ed32 into go-openapi:master Oct 9, 2021
@koron koron deleted the multiplatform-test-gha branch September 2, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants