Copy runtime.File as swag.File #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youyuanwu
approved these changes
Jan 29, 2022
|
Let me rebase the branch to skip Travis CI. |
The File type is defined in go-openapi/runtime and used from go-openapi/validate. However the runtime package uses the validate package which makes a circular dependency between them. go-openapi/validate#143 Signed-off-by: Kazuyoshi Kato <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
==========================================
- Coverage 88.84% 88.59% -0.26%
==========================================
Files 12 13 +1
Lines 1390 1394 +4
==========================================
Hits 1235 1235
- Misses 130 134 +4
Partials 25 25
Continue to review full report at Codecov.
|
|
@casualjim I think move File from runtime to here is ok. Please merge it if this looks ok. |
casualjim
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The File type is defined in go-openapi/runtime and used from
go-openapi/validate. However the runtime package uses the validate
package which makes a circular dependency between them.
go-openapi/validate#143
Signed-off-by: Kazuyoshi Kato [email protected]