Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Orthogonal defaulting and new pruning algorithm" #84

Closed
wants to merge 1 commit into from

Conversation

casualjim
Copy link
Member

@casualjim casualjim commented Apr 15, 2018

Do not merge yet!
Reverts #81

@codecov
Copy link

codecov bot commented Apr 15, 2018

Codecov Report

Merging #84 into master will increase coverage by 2.38%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
+ Coverage   96.75%   99.14%   +2.38%     
==========================================
  Files          18       19       +1     
  Lines        2222     2099     -123     
==========================================
- Hits         2150     2081      -69     
+ Misses         64       12      -52     
+ Partials        8        6       -2
Impacted Files Coverage Δ
helpers.go 95.32% <ø> (ø) ⬆️
schema_props.go 100% <100%> (ø) ⬆️
object_validator.go 98.11% <100%> (+0.01%) ⬆️
result.go 100% <100%> (+26.21%) ⬆️
schema.go 100% <100%> (ø) ⬆️
defaulter.go 100% <100%> (ø)
slice_validator.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6c59cf...59002dc. Read the comment docs.

@casualjim casualjim closed this Apr 16, 2018
@casualjim casualjim deleted the revert-81-sttts-orthogonal-defaulting branch April 18, 2018 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant