Add handling for job hooks with build payloads #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toshik1978
reviewed
Jul 17, 2020
gitlab/payload.go
Outdated
| @@ -139,7 +139,7 @@ type BuildEventPayload struct { | |||
| BuildStatus string `json:"build_status"` | |||
| BuildStartedAt customTime `json:"build_started_at"` | |||
| BuildFinishedAt customTime `json:"build_finished_at"` | |||
| BuildDuration int64 `json:"build_duration"` | |||
| BuildDuration float64 `json:"build_duration"` | |||
There was a problem hiding this comment.
I have some doubts here @zrochler in terms of backward compatibility... Due to documentation you should be right, but is it possible, that smbd already used this payload in old way...
There was a problem hiding this comment.
@Toshik1978 you're probably right. I don't remember what specifically led me to that change and whether it was because I saw it misbehaving, but I undid that change to avoid breaking anyone.
There was a problem hiding this comment.
@zrochler Zach, but it's a good question actually. Do we have float or int in real payload?
I'm preparing v6 branch at this moment. So we can do backward incompatible changes during 6.0.0 release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went with a similar approach to system hooks in requiring that both job and build events be requested so the caller has to be aware of this combination.
Fixes #95