Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse Github pull request labels from pull request payload. #28

Merged
merged 1 commit into from
Apr 8, 2018

Conversation

rtnpro
Copy link
Contributor

@rtnpro rtnpro commented Apr 2, 2018

As per https://developer.github.com/v3/pulls/#response-1, the pull request payload includes a field labels which contains a list of label map items.

image

However, it's not shown in the example: https://developer.github.com/v3/activity/events/types/#pullrequestevent for webhook events, although it references the pull_request object definition from https://developer.github.com/v3/pulls. I'd presume as a documentation bug on this Github help page.

This pull request adds support to parse Labels from a pull_request JSON object when unmarshalling pull_request event payload.

@rtnpro
Copy link
Contributor Author

rtnpro commented Apr 8, 2018

@joeybloggs ping! Could you review this change and let me know if it needs some more changes so that it can be merged?

@deankarn
Copy link
Collaborator

deankarn commented Apr 8, 2018

@rtnpro thanks for the ping, will merge asap

@deankarn deankarn merged commit 8db8abb into go-playground:v3 Apr 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants