Add gogs support #29
Add gogs support #29
Conversation
|
@joeybloggs ping |
|
Sorry for the late reply, been a busy day @naiba Thanks for the PR will try to get to it tomorrow :) it looks like some checks failed so will also need to look at that, probably just because if the gopkg.in imports. |
|
@naiba thank you for your work! I was wondering if you would be able to add some tests also? |
|
@joeybloggs I'm already using it, and I don't want to add a test |
|
@naiba fair enough, I'll try and get it merged tomorrow and open a separate issue for anyone wanting to help add tests :) Thanks again for your work on this! |
|
@joeybloggs thank you. I hope to merge as soon as possible, because I need to use it. |
bitbucket/bitbucket.go
Outdated
| @@ -43,7 +43,7 @@ const ( | |||
| PullRequestDeclinedEvent Event = "pullrequest:rejected" | |||
| PullRequestCommentCreatedEvent Event = "pullrequest:comment_created" | |||
| PullRequestCommentUpdatedEvent Event = "pullrequest:comment_updated" | |||
| PullRequestCommentDeletedEvent Event = "pullrequest:comment_deleted" | |||
| PullRequestCommentDeletedEvent Event = "pull_request:comment_deleted" | |||
There was a problem hiding this comment.
I think this may have been a merge issue, but docs say it's pullrequest
gogs/gogs.go
Outdated
| webhooks.DefaultLog.Error("HMAC verification failed") | ||
| webhooks.DefaultLog.Debug("LocalHMAC:" + expectedMAC) | ||
| webhooks.DefaultLog.Debug("RemoteHMAC:" + signature) | ||
| webhooks.DefaultLog.Debug("Secret:" + hook.secret) |
There was a problem hiding this comment.
Logging this is a huge security risk, will need to be removed
|
Thanks Will try to merge once I'm off the train |
Gogs is a painless self-hosted Git service. https://gogs.io