Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment Payload fields should be of type string. #33

Merged
merged 1 commit into from
Jun 28, 2018

Conversation

kishorenc
Copy link
Contributor

I wanted to use the Deployment object's Payload field but it was an empty struct. It should be a string, as per the following snippet of an actual webhook delivery from Github:

{
  "deployment": {
    "url": "https://api.github.com/repos/<redacted>",
    "id": 91231524,
    "node_id": "MDEwOkRlcGyveW12bnr5MjMzNDUyNA==",
    "sha": "9ece132423201xcd8fefbf54e42d78e6f2c3d705",
    "ref": "9ece132423201xcd8fefbf54e42d78e6f2c3d705",
    "task": "deploy",
    "payload": "{\"branch\":\"throwaway_june18_2018\",\"prNumber\":226,\"prUrl\":\"https://api.github.com/repos/<redacted>\"}",
    "environment": "staging",
    "description": "Deploying <redacted>",
    "creator": {
    ...

I've been using this fork successfully for a week and the deployments have been fine.

@deankarn deankarn merged commit 84dc839 into go-playground:v3 Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants