point to the same context after http.Request created #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
==========================================
+ Coverage 96.15% 96.17% +0.01%
==========================================
Files 9 9
Lines 1119 1123 +4
==========================================
+ Hits 1076 1080 +4
Misses 23 23
Partials 20 20
Continue to review full report at Codecov.
|
jeevatkm
reviewed
Jan 4, 2019
| @@ -67,6 +70,9 @@ func (r *Request) Context() context.Context { | |||
| // documentation. | |||
| func (r *Request) SetContext(ctx context.Context) *Request { | |||
| r.ctx = ctx | |||
| if r.RawRequest != nil { | |||
| @@ -55,6 +55,9 @@ type Request struct { | |||
| // Context method returns the Context if its already set in request | |||
| // otherwise it creates new one using `context.Background()`. | |||
| func (r *Request) Context() context.Context { | |||
| if r.RawRequest != nil { | |||
|
I understand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds checks related to context methods. When http.Request is created, context between resty.Request and http.Request stays the same. This can avoid mess when working with preReqHook.
See #206