Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multipart/form-data without filename and content type #236

Merged
merged 1 commit into from
Jun 18, 2019

Conversation

larryhu
Copy link
Contributor

@larryhu larryhu commented Mar 14, 2019

Sometime just want send fields without file when content-type is multipart/form-data

@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #236 into v2 will decrease coverage by 0.25%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v2     #236      +/-   ##
==========================================
- Coverage   95.81%   95.56%   -0.26%     
==========================================
  Files           9        9              
  Lines        1076     1082       +6     
==========================================
+ Hits         1031     1034       +3     
- Misses         24       25       +1     
- Partials       21       23       +2
Impacted Files Coverage Δ
util.go 90.64% <66.66%> (-1.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46fc51a...7376d9f. Read the comment docs.

@moorereason
Copy link
Contributor

Please add tests to this PR.

Copy link
Member

@jeevatkm jeevatkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larryhu Thank you for targeting v2 branch. Could you please add test cases for the PR?

Thanks @moorereason

@jeevatkm
Copy link
Member

@larryhu ping for unit test cases.

@jeevatkm
Copy link
Member

It seems like contributor @larryhu didn't get a chance to add a unit test case for this PR. So I'm merging in and adding a unit test. Kindly ensure next time, thank you!

@jeevatkm jeevatkm added this to the v2.0.0 Milestone milestone Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants