Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added capacity to slice creation, when capacity is known #277

Merged
merged 2 commits into from
Oct 10, 2019

Conversation

vivekv96
Copy link
Contributor

@vivekv96 vivekv96 commented Oct 9, 2019

Simple optimisation to reduce memory allocations and copying(while appending).

@codecov
Copy link

codecov bot commented Oct 9, 2019

Codecov Report

Merging #277 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #277   +/-   ##
=======================================
  Coverage   95.48%   95.48%           
=======================================
  Files           9        9           
  Lines        1152     1152           
=======================================
  Hits         1100     1100           
  Misses         29       29           
  Partials       23       23
Impacted Files Coverage Δ
util.go 90.25% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a893c37...7f7a85d. Read the comment docs.

Copy link
Member

@jeevatkm jeevatkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vivekv96 Thank you for the PR and improving the Resty.

I have made updates regarding other PR for debug log, due to that your PR ended up with conflicts. Can you please resolve it?

Copy link
Member

@jeevatkm jeevatkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vivekv96 No worries, I'm working on v2.1.0 release so I have resolved the conflicts. Thanks!

@jeevatkm jeevatkm added this to the v2.1.0 Milestone milestone Oct 10, 2019
@jeevatkm jeevatkm merged commit 7a4c9b3 into go-resty:master Oct 10, 2019
@vivekv96
Copy link
Contributor Author

@jeevatkm Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants