Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-proper position for subsection in toc.ncx #12

Closed
ChengShusss opened this issue Oct 16, 2023 · 0 comments · Fixed by #13
Closed

Non-proper position for subsection in toc.ncx #12

ChengShusss opened this issue Oct 16, 2023 · 0 comments · Fixed by #13
Labels
bug Something isn't working

Comments

@ChengShusss
Copy link

A subsection should belong to its section in toc.ncx, for proper show in reader.

Currently subsection is the same as section in toc.ncx
ChengShusss pushed a commit to ChengShusss/go-epub that referenced this issue Oct 16, 2023
fix: misplaced subsection position in toc.ncx (go-shiori#12)
4124542
@Monirzadeh Monirzadeh added the bug Something isn't working label Oct 23, 2023
@Monirzadeh Monirzadeh mentioned this issue Oct 23, 2023
Merged
@Monirzadeh Monirzadeh linked a pull request Oct 23, 2023 that will close this issue
fix: misplaced subsection position in toc.ncx #13
Merged
Monirzadeh pushed a commit that referenced this issue Oct 29, 2023
@ChengShusss
fix: misplaced subsection position in toc.ncx (#13)
8db857c 
fix: misplaced subsection position in toc.ncx (#12)

Co-authored-by: ChengShusss <cheng.s.shu@foxmail>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: misplaced subsection position in toc.ncx ChengShusss/go-epub
2 participants
@Monirzadeh @ChengShusss