Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Title is never retrieved when adding bookmark #654

Closed
fmartingr opened this issue Jul 21, 2023 · 0 comments · Fixed by #664
Closed

Title is never retrieved when adding bookmark #654

fmartingr opened this issue Jul 21, 2023 · 0 comments · Fixed by #664
Assignees
@fmartingr
Labels
component:backend good first issue Good for newcomers priority:high type:bug Something isn't working
Milestone
1.6.0

Comments

@fmartingr
Copy link
Member

Heads up: title is never retrieved
https://github.com/go-shiori/shiori/blob/v1.5.5-rc.1/internal/webserver/handler-api.go#L320-L322

// Make sure bookmark's title not empty
if book.Title == "" {
    book.Title = book.URL
}
// ^ because if this
// …
        bookmark, err := downloadBookmarkContent(book, h.DataDir, r, book.Title != "", book.Excerpt != "")
//                                                                   ^ it's always non-empty
// …
    book, err = downloadBookmarkContent(book, h.DataDir, r, book.Title != "", book.Excerpt != "")
//                                                          ^ it's always non-empty

Originally posted by @eitau in #637 (comment)
@fmartingr fmartingr added type:bug Something isn't working good first issue Good for newcomers component:backend labels Jul 21, 2023
@fmartingr fmartingr mentioned this issue Jul 21, 2023
Closed
@github-project-automation github-project-automation bot moved this to To do in Roadmap Jul 21, 2023
@fmartingr fmartingr added this to the 1.6.0 milestone Jul 21, 2023
@fmartingr fmartingr self-assigned this Jul 21, 2023
@fmartingr fmartingr moved this from To do to In progress in Roadmap Jul 21, 2023
fmartingr added a commit that referenced this issue Jul 21, 2023
@fmartingr
fix: title is never retrieved when adding bookmark
4ee64ae 
Fixes #654
@fmartingr fmartingr mentioned this issue Jul 21, 2023
Merged
fmartingr added a commit that referenced this issue Jul 21, 2023
@fmartingr
fix: title is never retrieved when adding bookmark (#664)
622d556 
* fix: title is never retrieved when adding bookmark

Fixes #654
@github-project-automation github-project-automation bot moved this from In progress to Done in Roadmap Jul 21, 2023
@fmartingr fmartingr mentioned this issue Jul 29, 2023
Merged
@Sissing Sissing mentioned this issue Jan 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmartingr fmartingr

Labels
component:backend good first issue Good for newcomers priority:high type:bug Something isn't working
Projects
Roadmap
Archived in project
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

fix: title is never retrieved when adding bookmark go-shiori/shiori
1 participant
@fmartingr