Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Mac LaunchAgent instructions #1002

Merged
merged 4 commits into from
Nov 17, 2024

Conversation

cdaein
Copy link
Contributor

@cdaein cdaein commented Oct 19, 2024

From #999

Instructions for Mac LaunchAgent so the Shiori server will start at login automatically.

Note:
I tested on my Mac but it would be nice if someone else can also do a test to make sure.
Thanks!

Instructions for Mac LaunchAgent so the Shiori server will start at
login automatically.
@Monirzadeh Monirzadeh requested a review from fmartingr October 20, 2024 02:04
Copy link
Member

@fmartingr fmartingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! Really appreciated.

I think is best if we put the macOS setup under it's own section, I've left a comment about that. Just don't forget to update the table of contents and we're good to go :)

docs/Frequently-Asked-Question.md Show resolved Hide resolved
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.74%. Comparing base (6b6d5f3) to head (c43aa5b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1002   +/-   ##
=======================================
  Coverage   34.74%   34.74%           
=======================================
  Files          61       61           
  Lines        5322     5322           
=======================================
  Hits         1849     1849           
  Misses       3249     3249           
  Partials      224      224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fmartingr fmartingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thank you for your contribution. :)

@fmartingr fmartingr merged commit 660d425 into go-shiori:master Nov 17, 2024
13 checks passed
@cdaein cdaein deleted the mac-launch-agent branch November 17, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants