Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: postgresql migration not working with other languages #1013

Merged
merged 11 commits into from
Dec 11, 2024

Conversation

fmartingr
Copy link
Member

@fmartingr fmartingr commented Nov 16, 2024

Fix an error for postgres migrations on different languages, checking for the error code from postgres instead of comparing strings.

Closes #996

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 53.84615% with 12 lines in your changes missing coverage. Please review.

Project coverage is 34.72%. Comparing base (7b6fad8) to head (0c18db9).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/database/pg.go 53.84% 10 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1013      +/-   ##
==========================================
+ Coverage   34.66%   34.72%   +0.06%     
==========================================
  Files          61       61              
  Lines        5316     5324       +8     
==========================================
+ Hits         1843     1849       +6     
- Misses       3249     3251       +2     
  Partials      224      224              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmartingr fmartingr self-assigned this Dec 11, 2024
@fmartingr fmartingr force-pushed the fix/migration-quotes branch from ee654b2 to 8aecb98 Compare December 11, 2024 11:21
@fmartingr fmartingr marked this pull request as ready for review December 11, 2024 11:57
@fmartingr fmartingr changed the title fix: word check on migration error fix: postgresql migration not working with other languages Dec 11, 2024
@fmartingr fmartingr merged commit 4aa0f51 into master Dec 11, 2024
17 checks passed
@fmartingr fmartingr deleted the fix/migration-quotes branch December 11, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postresql: Start of Shiori fails with "failed to run migration from 0.2.0 to 0.3.0:" after fresh installation
1 participant