feat: add SHIORI_PG_SSLMODE #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some managed hosting providers don't support sslmode=disabled.
fmartingr
approved these changes
Nov 27, 2022
internal/cmd/root.go
Outdated
| @@ -135,8 +135,12 @@ func openPostgreSQLDatabase(ctx context.Context) (database.DB, error) { | |||
| user, _ := os.LookupEnv("SHIORI_PG_USER") | |||
| password, _ := os.LookupEnv("SHIORI_PG_PASS") | |||
| dbName, _ := os.LookupEnv("SHIORI_PG_NAME") | |||
| sslmode, ok := os.LookupEnv("SHIORI_PG_SSLMODE") | |||
There was a problem hiding this comment.
Keep in mind that in this case ok will be true in the case SHIORI_PG_SSLMODE is an empty string. Unsure how Posgres will react to that. Maybe is better to check for sslMode == "".
|
When will this PR be merged into the master? |
Waiting for this comment to be addressed. |
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some managed hosting providers don't support sslmode=disabled.