-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade go-spatial/geom to latest #952
Conversation
@@ -345,7 +345,7 @@ func TestEncode(t *testing.T) { | |||
}, | |||
}, | |||
}, | |||
tile: slippy.NewTile(2, 3, 4), | |||
tile: slippy.NewTile(2, 3, 3), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 is not a valid y-value at zoom 2, and the geom upgrade makes this test fail unless a valid coordinate is used.
3f4a674
to
f35d63d
Compare
@jchamberlain could you please split this PR into 2 commits: 1 for the vendoring of |
f35d63d
to
2e8162d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There are some minor code cleanups; that we can get to later. And we should make an issue around renaming slippy.PixelsToNative.
@jchamberlain can you rebase against master? I just fixed the docker hub issue (and upgraded Go in the CI) so we can get the CI to pass. Then I can merge this in. |
2e8162d
to
a6f1b0c
Compare
Pull Request Test Coverage Report for Build 4ce028e55-PR-952
💛 - Coveralls |
This addresses the second point in #951. The main changes impacting this project are in the
slippy
package, and include:slippy.Tile
directly.Extent3857()
,Extent4326()
), thus requiring use a another tool for transformations.slippy.RangeFamilyAt()
, thus requiring keeping around the old version of that function.