Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: db driven platform settings #554

Merged
merged 36 commits into from
May 15, 2024
Merged

feat: db driven platform settings #554

merged 36 commits into from
May 15, 2024

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented Apr 30, 2024

cli implementation for #go-vela/server/1110

@plyr4 plyr4 requested a review from a team as a code owner April 30, 2024 14:36
command/pipeline/exec.go Show resolved Hide resolved
command/pipeline/exec.go Show resolved Hide resolved
command/pipeline/exec.go Show resolved Hide resolved
command/pipeline/validate.go Show resolved Hide resolved
command/pipeline/validate.go Show resolved Hide resolved
command/pipeline/exec.go Show resolved Hide resolved
command/pipeline/exec.go Show resolved Hide resolved
command/pipeline/validate.go Show resolved Hide resolved
command/pipeline/validate.go Show resolved Hide resolved
command/pipeline/validate.go Show resolved Hide resolved
command/settings/update.go Show resolved Hide resolved
action/settings/update.go Outdated Show resolved Hide resolved
action/settings/view.go Show resolved Hide resolved
@plyr4 plyr4 changed the title feat: tweaks for platform settings structs feat: db driven platform settings May 13, 2024
action/settings/update.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 48.12834% with 97 lines in your changes are missing coverage. Please review.

Project coverage is 79.90%. Comparing base (f58e94d) to head (a1bf687).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #554      +/-   ##
==========================================
- Coverage   81.38%   79.90%   -1.48%     
==========================================
  Files         156      161       +5     
  Lines        3803     3982     +179     
==========================================
+ Hits         3095     3182      +87     
- Misses        519      581      +62     
- Partials      189      219      +30     
Files Coverage Δ
action/dashboard/update.go 75.47% <ø> (ø)
action/settings/validate.go 100.00% <100.00%> (ø)
command/pipeline/validate.go 71.42% <75.00%> (ø)
action/settings/view.go 88.23% <88.23%> (ø)
command/pipeline/exec.go 0.00% <0.00%> (ø)
command/settings/view.go 57.14% <57.14%> (ø)
command/settings/update.go 56.25% <56.25%> (ø)
action/settings/update.go 38.05% <38.05%> (ø)

action/settings/update.go Show resolved Hide resolved
action/settings/update.go Show resolved Hide resolved
action/settings/update.go Show resolved Hide resolved
command/settings/update.go Outdated Show resolved Hide resolved
command/settings/update.go Outdated Show resolved Hide resolved
action/settings/update.go Show resolved Hide resolved
Copy link
Contributor

@ecrupper ecrupper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked well for me in testing 👍 LGTM

@plyr4 plyr4 merged commit b1e221d into main May 15, 2024
15 of 17 checks passed
@plyr4 plyr4 deleted the feat/platform-settings branch May 15, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants