-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow setting --force-build-metadata flag for /kaniko/executor #102
Merged
wass3r
merged 7 commits into
go-vela:master
from
ericdstein:support_forcebuildmetadata_flag
Feb 18, 2022
Merged
feat: allow setting --force-build-metadata flag for /kaniko/executor #102
wass3r
merged 7 commits into
go-vela:master
from
ericdstein:support_forcebuildmetadata_flag
Feb 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericdstein
force-pushed
the
support_forcebuildmetadata_flag
branch
from
December 13, 2021 07:03
f8cfa09
to
a16143f
Compare
kneal
changed the title
allow setting --force-build-metadata flag for /kaniko/executor
feat: allow setting --force-build-metadata flag for /kaniko/executor
Dec 14, 2021
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
==========================================
- Coverage 43.79% 43.05% -0.75%
==========================================
Files 7 7
Lines 580 590 +10
==========================================
Hits 254 254
- Misses 325 334 +9
- Partials 1 2 +1
|
dtanner
previously approved these changes
Jan 18, 2022
…ericdstein/vela-kaniko into support_forcebuildmetadata_flag
kaymckay
approved these changes
Feb 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for the add 👍
jbrockopp
approved these changes
Feb 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wass3r
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to set
--force-build-metadata
flag of/kaniko/executor
.A new flag
--force-build-metadata
was added to kaniko thatforces layers with no files to be added to the image
. One use case is keeping the layer that contains metadata ofRUN USER
.