Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(logs): Replace "Pulling" with "Preparing" in init step logs #287

Merged
merged 1 commit into from
Mar 15, 2022
Merged

refactor(logs): Replace "Pulling" with "Preparing" in init step logs #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions executor/linux/build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ func (c *client) PlanBuild(ctx context.Context) error {
// update the init log with progress
//
// https://pkg.go.dev/github.com/go-vela/types/library?tab=doc#Log.AppendData
_log.AppendData([]byte("> Pulling secrets...\n"))
_log.AppendData([]byte("> Preparing secrets...\n"))

// iterate through each secret provided in the pipeline
for _, secret := range c.pipeline.Secrets {
Expand Down Expand Up @@ -231,7 +231,7 @@ func (c *client) AssembleBuild(ctx context.Context) error {
// update the init log with progress
//
// https://pkg.go.dev/github.com/go-vela/types/library?tab=doc#Log.AppendData
_log.AppendData([]byte("> Pulling service images...\n"))
_log.AppendData([]byte("> Preparing service images...\n"))

// create the services for the pipeline
for _, s := range c.pipeline.Services {
Expand Down Expand Up @@ -262,7 +262,7 @@ func (c *client) AssembleBuild(ctx context.Context) error {
// update the init log with progress
//
// https://pkg.go.dev/github.com/go-vela/types/library?tab=doc#Log.AppendData
_log.AppendData([]byte("> Pulling stage images...\n"))
_log.AppendData([]byte("> Preparing stage images...\n"))

// create the stages for the pipeline
for _, s := range c.pipeline.Stages {
Expand All @@ -284,7 +284,7 @@ func (c *client) AssembleBuild(ctx context.Context) error {
// update the init log with progress
//
// https://pkg.go.dev/github.com/go-vela/types/library?tab=doc#Log.AppendData
_log.AppendData([]byte("> Pulling step images...\n"))
_log.AppendData([]byte("> Preparing step images...\n"))

// create the steps for the pipeline
for _, s := range c.pipeline.Steps {
Expand Down Expand Up @@ -317,7 +317,7 @@ func (c *client) AssembleBuild(ctx context.Context) error {
// update the init log with progress
//
// https://pkg.go.dev/github.com/go-vela/types/library?tab=doc#Log.AppendData
_log.AppendData([]byte("> Pulling secret images...\n"))
_log.AppendData([]byte("> Preparing secret images...\n"))

// create the secrets for the pipeline
for _, s := range c.pipeline.Secrets {
Expand Down
2 changes: 1 addition & 1 deletion executor/linux/stage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ func (c *client) CreateStage(ctx context.Context, s *pipeline.Stage) error {
// update the init log with progress
//
// https://pkg.go.dev/github.com/go-vela/types/library?tab=doc#Log.AppendData
_log.AppendData([]byte(fmt.Sprintf("> Pulling step images for stage %s...\n", s.Name)))
_log.AppendData([]byte(fmt.Sprintf("> Preparing step images for stage %s...\n", s.Name)))

// create the steps for the stage
for _, _step := range s.Steps {
Expand Down
6 changes: 3 additions & 3 deletions executor/local/build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ func (c *client) AssembleBuild(ctx context.Context) error {
}

// output init progress to stdout
fmt.Fprintln(os.Stdout, _pattern, "> Pulling service images...")
fmt.Fprintln(os.Stdout, _pattern, "> Preparing service images...")

// create the services for the pipeline
for _, _service := range c.pipeline.Services {
Expand All @@ -187,7 +187,7 @@ func (c *client) AssembleBuild(ctx context.Context) error {
}

// output init progress to stdout
fmt.Fprintln(os.Stdout, _pattern, "> Pulling stage images...")
fmt.Fprintln(os.Stdout, _pattern, "> Preparing stage images...")

// create the stages for the pipeline
for _, _stage := range c.pipeline.Stages {
Expand All @@ -206,7 +206,7 @@ func (c *client) AssembleBuild(ctx context.Context) error {
}

// output init progress to stdout
fmt.Fprintln(os.Stdout, _pattern, "> Pulling step images...")
fmt.Fprintln(os.Stdout, _pattern, "> Preparing step images...")

// create the steps for the pipeline
for _, _step := range c.pipeline.Steps {
Expand Down
2 changes: 1 addition & 1 deletion executor/local/stage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ func (c *client) CreateStage(ctx context.Context, s *pipeline.Stage) error {
_pattern := fmt.Sprintf(stagePattern, c.init.Name, c.init.Name)

// output init progress to stdout
fmt.Fprintln(os.Stdout, _pattern, "> Pulling step images for stage", s.Name, "...")
fmt.Fprintln(os.Stdout, _pattern, "> Preparing step images for stage", s.Name, "...")

// create the steps for the stage
for _, _step := range s.Steps {
Expand Down