Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: silence lint issues #305

Closed
wants to merge 0 commits into from
Closed

refactor: silence lint issues #305

wants to merge 0 commits into from

Conversation

cognifloyd
Copy link
Member

These are already silenced in several other places. So, let's get reviewdog full-review to stop complaining.

@cognifloyd cognifloyd requested a review from a team as a code owner April 14, 2022 17:46
@cognifloyd cognifloyd added the enhancement Indicates an improvement to a feature label Apr 14, 2022
@cognifloyd cognifloyd self-assigned this Apr 14, 2022
@codecov
Copy link

codecov bot commented Apr 14, 2022 •
edited
Loading

Codecov Report

Merging #305 (b73d804) into master (c091a57) will not change coverage.
The diff coverage is n/a.

❗ Current head b73d804 differs from pull request most recent head c091a57. Consider uploading reports for the commit c091a57 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #305   +/-   ##
=======================================
  Coverage   79.77%   79.77%           
=======================================
  Files          67       67           
  Lines        4958     4958           
=======================================
  Hits         3955     3955           
  Misses        859      859           
  Partials      144      144

@cognifloyd
Copy link
Member Author

🎉 This makes reviewdog / full-revew green!

wass3r
wass3r reviewed Apr 14, 2022
View reviewed changes
Copy link
Collaborator

@wass3r wass3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm. there are no changes ?

@cognifloyd
Copy link
Member Author

I targeted the wrong branch. dang it.

@cognifloyd cognifloyd closed this Apr 14, 2022
@cognifloyd cognifloyd mentioned this pull request Apr 14, 2022
Merged
@cognifloyd
Copy link
Member Author

@wass3r Please see #307 instead. 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wass3r wass3r wass3r left review comments

Assignees

@cognifloyd cognifloyd

Labels
enhancement Indicates an improvement to a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cognifloyd @wass3r