Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: silence lint issues #307

Merged
merged 1 commit into from
Apr 16, 2022
Merged

refactor: silence lint issues #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions executor/context_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ func TestExecutor_FromContext(t *testing.T) {
want Engine
}{
{
// nolint: staticcheck // ignore using string with context value
// nolint: staticcheck,revive // ignore using string with context value
context: context.WithValue(context.Background(), key, _engine),
want: _engine,
},
Expand All @@ -64,7 +64,7 @@ func TestExecutor_FromContext(t *testing.T) {
want: nil,
},
{
// nolint: staticcheck // ignore using string with context value
// nolint: staticcheck,revive // ignore using string with context value
context: context.WithValue(context.Background(), key, "foo"),
want: nil,
},
Expand Down Expand Up @@ -173,7 +173,7 @@ func TestExecutor_WithContext(t *testing.T) {
t.Errorf("unable to create linux engine: %v", err)
}

// nolint: staticcheck // ignore using string with context value
// nolint: staticcheck,revive // ignore using string with context value
want := context.WithValue(context.Background(), key, _engine)

// run test
Expand Down
1 change: 1 addition & 0 deletions mock/docker/docker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ const Version = "v1.40"

// New returns a client that is capable of handling
// Docker client calls and returning stub responses.
// nolint:revive // ignore unexported type as it is intentional
func New() (*mock, error) {
return &mock{
ConfigService: ConfigService{},
Expand Down
6 changes: 3 additions & 3 deletions runtime/context_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ func TestRuntime_FromContext(t *testing.T) {
want Engine
}{
{
// nolint: staticcheck // ignore using string with context value
// nolint: staticcheck,revive // ignore using string with context value
context: context.WithValue(context.Background(), key, _engine),
want: _engine,
},
Expand All @@ -38,7 +38,7 @@ func TestRuntime_FromContext(t *testing.T) {
want: nil,
},
{
// nolint: staticcheck // ignore using string with context value
// nolint: staticcheck,revive // ignore using string with context value
context: context.WithValue(context.Background(), key, "foo"),
want: nil,
},
Expand Down Expand Up @@ -109,7 +109,7 @@ func TestRuntime_WithContext(t *testing.T) {
t.Errorf("unable to create runtime engine: %v", err)
}

// nolint: staticcheck // ignore using string with context value
// nolint: staticcheck,revive // ignore using string with context value
want := context.WithValue(context.Background(), key, _engine)

// run test
Expand Down