Skip to content
This repository has been archived by the owner on Jun 19, 2019. It is now read-only.

Add UniqueIdentifier type for supporting mssql #38

Merged
merged 1 commit into from
Feb 23, 2018

Conversation

p581581
Copy link
Contributor

@p581581 p581581 commented Feb 22, 2018

Add UniqueIdentifier type and recognize it as byte array.

Verified

This commit was signed with the committer’s verified signature.
vbudhram Vijay Budhram
@lunny
Copy link
Member

lunny commented Feb 22, 2018

Is UniqueIdentifier similar with UUID type? Maybe we should return string but not []byte?

@p581581
Copy link
Contributor Author

p581581 commented Feb 22, 2018

Yeah, it is UUID type. But, for now, it parses incorrectly, if we recognize it as string. Also, UUID is a 128-bit number which would be faster than Varchar(36).

@lunny
Copy link
Member

lunny commented Feb 22, 2018

@p581581 I cannot confirm that. Have you run this patch successfully?

@p581581
Copy link
Contributor Author

p581581 commented Feb 23, 2018

Yeah, it works fine, but still need to parse it to string when passing parameter.

@lunny lunny merged commit c624c83 into go-xorm:master Feb 23, 2018
@lunny
Copy link
Member

lunny commented Feb 23, 2018

@p581581 Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants