fix: scalar indent indicator [#643] #864
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emanlodovice
suggested changes
Feb 10, 2023
hedhyw
force-pushed
the
fix/indent-indicator
branch
from
18a3b13 to
bede512
Compare
hedhyw
changed the title
|
Approved the PR but I am not a maintainer 😅 |
|
@niemeyer please take a look when you have time. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #643
The library can produce invalid YAML (
yaml.Marshal([]string{" hello\nworld"})):The indention is
2, but the indicator shows4-.This PR fixes this behaviour.