Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] add more method docs #61

Merged
merged 1 commit into from
Jul 9, 2021
Merged

[doc] add more method docs #61

merged 1 commit into from
Jul 9, 2021

Conversation

linsite
Copy link

@linsite linsite commented Jul 5, 2021

Add more docs for conn.go. Thanks for your time to review it.
#4

@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #61 (9fe1f81) into master (81dc762) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   76.36%   76.36%           
=======================================
  Files           7        7           
  Lines        1189     1189           
=======================================
  Hits          908      908           
  Misses        192      192           
  Partials       89       89           
Impacted Files Coverage Δ
conn.go 73.62% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81dc762...9fe1f81. Read the comment docs.

Copy link

@nemith nemith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM . Thank you again!

@nemith nemith merged commit 8866d76 into go-zookeeper:master Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants