GOAOP not working in Php7.1.3

[team-ultra]

Version Details
PHP 7.1.3 (cli)
GOAOP 2.1.0

I have made a simple goaop component, while running the code i have put debug on before method but it dosen't return expected result

Folder Structure

goaop
--- app
app.php
ApplicationAspectKernel.php
--- aspect
MonitorAspect.php
SampleClass.php

app.php

include __DIR__ . '/../vendor/autoload.php';
require_once 'ApplicationAspectKernel.php';
use Goaop\Aspect\SampleClass;

ApplicationAspectKernel::getInstance()->init(['appDir' => __DIR__,
    'cacheDir' => null, 'includePaths' => [], 'debug' => true]
);

$sampleClass = new SampleClass();
$sampleClass->testCondition();

ApplicationAspectKernel.php

<?php
// app/ApplicationAspectKernel.php

use Go\Core\AspectKernel;
use Go\Core\AspectContainer;
use Goaop\Aspect\MonitorAspect;

/**
 * Application Aspect Kernel
 */
class ApplicationAspectKernel extends AspectKernel
{

    /**
     * Configure an AspectContainer with advisors, aspects and pointcuts
     *
     * @param AspectContainer $container
     *
     * @return void
     */
    protected function configureAop(AspectContainer $container)
    {
		$container->registerAspect(new MonitorAspect());
    }
}

MonitorAspect.php

<?php
namespace Goaop\Aspect;

use Go\Aop\Aspect;
use Go\Aop\Intercept\FieldAccess;
use Go\Aop\Intercept\MethodInvocation;
use Go\Lang\Annotation\After;
use Go\Lang\Annotation\Before;
use Go\Lang\Annotation\Around;
use Go\Lang\Annotation\Pointcut;
use Goaop\Aspect\SampleClass;

class MonitorAspect implements Aspect
{

    /**
     * @param MethodInvocation $invocation Invocation
     * @Before("execution(public Goaop\Aspect\SampleClass->testCondition(*))")
     */
    public function beforeMethodExecution(MethodInvocation $invocation)
    {
        echo "Before method\n";
    }
}

SampleClass.php

<?php
namespace Goaop\Aspect;

class SampleClass {
	public function testCondition($test = "test") {
		echo "Test condition working fine\n";
	}
}

composer.json

{
    "require": {
        "goaop/framework": "^2.1"
    },
	"autoload": {
        "psr-4": {
          "Goaop\\Aspect\\": "aspect"
		}
	}
}

Expected Result:
Before method
Test condition working fine

Output
Test condition working fine

Same component which work in below configuration

Version Details
PHP 5.4 (cli)
GOAOP 0.5.0

please help me on this to resolve

thanks in advance
krishna

[lisachenko]

Hi! Sorry for the late response.

I manually checked your source code and detected several issues:

1. Your application rootDir option was set to the app folder and not to the aspect directory where test class is located, so AOP engine just ignores files from other directories. Need to specify valid directory, for example, 'appDir' => __DIR__ . '/../aspect'
2. You didn't specify valid cache directory to store transformed files and modern version of framework heavily rely on caching. There was also a bug in GoAspectContainer class, which is fixed now in the master branch. So you can try you example one more time with configured cacheDir or by updating AOP to the dev-master manually for testing.

[lisachenko]

After that you will get expected string:

Before method Test condition working fine 

[team-ultra]

Thank you so much @lisachenko, working as expected 👍

[lisachenko]

You are welcome!

[sonicoder86]

@lisachenko This issue is related to Codeception/AspectMock#146
When i specify the cache directory, throws another error.

It is definitely a breaking change introduced in a feature version.
Before cache directory was not necessary.