Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codeception unit tests fail with latest commit - df96f1c #88

Closed
mohangk opened this issue Aug 15, 2013 · 4 comments
Closed

Codeception unit tests fail with latest commit - df96f1c #88

mohangk opened this issue Aug 15, 2013 · 4 comments
Labels
Milestone

Comments

@mohangk
Copy link

mohangk commented Aug 15, 2013

The latest commit df96f1c has broken codeception within my Laravel app. When I lock my version of go-aop-php to "dev-master#98641c8", things work fine. But now when I try to run the same tests I get the following error:

{"error":{"type":"Symfony\Component\Debug\Exception\FatalErrorException","message":"syntax error, unexpected ';'","file":"/vagrant/bootstrap/start.php","line":46}}

That error happens to be the following line in the start.php this line https://github.com/mohangk/laravel_sample_app/blob/master/bootstrap/start.php#L46

Any help is appreciated

@lisachenko
Copy link
Member

@zVIRUSz This issue was introduced by PR #85 Can you have a look?
@mohangk Can you help us by submitting a small PR with broken test for this?

@andrey-yantsen
Copy link
Contributor

Ooops, sorry guys, fixed in #89.

@mohangk
Copy link
Author

mohangk commented Aug 16, 2013

@zVIRUSz is too fast 👍 Will try this fix later in the day.

I would like to write a failing spec, is there some place where I can read on how to setup and run the test suite for go-php ?

lisachenko added a commit that referenced this issue Aug 16, 2013
Fix includes inside function arguments, resolves #88
@lisachenko
Copy link
Member

@mohangk Running tests is pretty easy: just install the framework and run phpunit in it. You can also use an IDE for this such as phpStorm.

genkiroid pushed a commit to genkiroid/framework that referenced this issue Jun 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants