[Feature] New grammar definition #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notice, that there is a BC break, because syntax "* Some\ClassName->method(*)" and "* Some\ClassName->property" is removed
lisachenko
added a commit
that referenced
this pull request
Apr 29, 2015
[Feature] New grammar definition
This was referenced Apr 29, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to solve inconsistency and errors in the previous version of grammar.
This grammar correctly works with complex expression like this:
A && !B || (C && !D), but there is still an error in the logic of checking joinpoints (will be fixed in the separate PR)There is one small BC break in the pointcut syntax: asterisk sign can't be used now as specification of member visibility:
execution(* Some\ClassName->method(*))should be changed to the explicitexecution(public Some\ClassName->method(*)). You can combine several modifiers with|symbol, for examplepublic|protectedPartial implementation for #218