Proposition to improve the transformer workflow #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lisachenko it's just a proposition, give me your feedback. |
Wrap the source with the stream metadatas. Because, someone transformer need source, someone do not need source. With a global wrapper (the StreamMetaData), each transform is based on only one object.
|
@blanchonvincent good idea! 👍 This gives more stable interface for transformers. However, for future I want to use PHP-parser library and Abstract Syntax Tree as source instead of string and StreamMetaData. Transformers will be rewritten as node visitors, this will give more control on source code. |
genkiroid
pushed a commit
to genkiroid/framework
that referenced
this pull request
Jun 23, 2016
This should fix goaop#24.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap the source with the stream metadatas. Because, someone transformer
need source, someone do not need source. With a global wrapper (the
StreamMetaData), each transform is based on only one object.