Propose PHP <= 5.5 #305
Merged
Propose PHP <= 5.5 #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doctrine just launched Annotations 1.3.0 which is now PHP 5.6+.
|
Hi, there are errors in the composer.lock, please resolve them. |
lisachenko
requested changes
Dec 12, 2016
| @@ -8,9 +8,9 @@ | |||
| "license": "MIT", | |||
|
|
|||
| "require": { | |||
| "php": ">=5.5.0", | |||
| "php": "<=5.5.99", | |||
There was a problem hiding this comment.
It's better to use ~5.5.0 here.
There was a problem hiding this comment.
This would restrict the 1.x branch to PHP 5.5 only. Any reasons why not support PHP 5.3 / 5.4?
There was a problem hiding this comment.
5.3 and 5.4 are not supported, anyone who wants to use an old version, can switch to 0.x versions.
| "jakubledl/dissect": "~1.0", | ||
| "doctrine/annotations": "~1.0", | ||
| "doctrine/annotations": "<1.3.0", |
|
Can't find any issues in composer.lock. |
|
Merged, thanks |
|
Also, removed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propose PHP <= 5.5 for 1.x branch.