Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Implement parameter widening feature for generated code (#380) #383

Merged
merged 1 commit into from
Jan 8, 2018

Conversation

lisachenko
Copy link
Member

This PR introduces logic of skipping parameter types for children classes, according to the implemented in 7.2 parameter widening.

So, you can apply this feature to control manually parameter binding or conversion. This can be ParamConvertors, parameter injectors, etc..

To enable this feature, add into kernel initialization:

// Initialize demo aspect container
AspectKernel::getInstance()->init([
    // ... other config options
    'features' =>Features::PARAMETER_WIDENING,
]);

Please, remember, that this feature is available only for PHP>=7.2.0

@lisachenko lisachenko added this to the 3.0.0 milestone Jan 7, 2018
@lisachenko lisachenko requested a review from TheCelavi January 7, 2018 17:58
@scrutinizer-notifier
Copy link

The inspection completed: 1 updated code elements

@lisachenko
Copy link
Member Author

AppVeyor and SensioLabsInsight have glitches. Ignoring them...

@lisachenko lisachenko merged commit aed36ca into master Jan 8, 2018
@lisachenko lisachenko deleted the feature/parameter-widening branch January 8, 2018 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants