Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compatibility] Allow Symfony 5 components. #447

Merged
merged 1 commit into from
Apr 6, 2020
Merged

[Compatibility] Allow Symfony 5 components. #447

merged 1 commit into from
Apr 6, 2020

Conversation

func0der
Copy link
Contributor

@func0der func0der commented Apr 3, 2020

No description provided.

@scrutinizer-notifier
Copy link

The inspection completed: 1 new issues

@func0der
Copy link
Contributor Author

func0der commented Apr 3, 2020

This change is for a 2.x release, since 3.x is yet to come, a quick 2.x would be nice :)

@func0der
Copy link
Contributor Author

func0der commented Apr 6, 2020

@lisachenko Do you have an idea how to fix that build check?

@lisachenko
Copy link
Member

Do you have an idea how to fix that build check?

Hmm, this can be an issue in the SymfonyInsight itself, as it tries to install version of package with incorrect PHP version.

@lisachenko
Copy link
Member

Also, I don't see build results from Travis...

@lisachenko lisachenko merged commit f980f24 into goaop:2.x Apr 6, 2020
@lisachenko lisachenko added this to the 2.3.4 milestone Apr 6, 2020
@lisachenko
Copy link
Member

Tagged patch release 2.3.4

@func0der func0der deleted the allow_symfony_5 branch April 6, 2020 09:53
@lisachenko lisachenko changed the title [allow_symfony_5] Allow symfony 5 components. [Compatibility] Allow Symfony 5 components. Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants