Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patches #1560

Merged
merged 4 commits into from
Sep 20, 2022
Merged

Patches #1560

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/api/src/crud/crud_customization.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ async def build_layer_category_obj(self, db: AsyncSession, layer_name: str):
"access_token",
"max_resolution",
"max_resolution",
"doc_url"
]:
if getattr(layer, key) is not None:
layer_attributes[key] = getattr(layer, key)
Expand Down
46 changes: 41 additions & 5 deletions app/client/src/components/indicators/Indicators.vue
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,38 @@
layer.get('showOptions') === true
}"
>
<v-expansion-panel-header expand-icon="" v-slot="{}">
<v-layout row class="pl-1" wrap align-center>
<v-expansion-panel-header
expand-icon=""
v-slot="{}"
class="pl-0 ml-0"
>
<v-layout row class="pl-0 ml-0" wrap align-center>
<v-flex class="checkbox" xs1>
<v-tooltip top>
<template v-slot:activator="{ on }">
<v-btn
v-on="on"
@click.stop="openDocumentation(layer)"
v-show="layer.get('docUrl')"
class="ma-0 pb-0"
small
text
icon
>
<i class="fas fa-info"></i>
</v-btn>
</template>
<span>{{ $t(`map.tooltips.openDocumentation`) }}</span>
</v-tooltip>
</v-flex>
<v-flex class="checkbox" xs1>
<v-checkbox
:color="appColor.secondary"
:input-value="layer.getVisible()"
@change="toggleLayerVisibility(layer)"
></v-checkbox>
</v-flex>
<v-flex xs10 class="light-text">
<v-flex xs9 class="light-text">
<h4 class="pl-2">
{{ translate("layerName", layer.get("name")) }}
</h4>
Expand Down Expand Up @@ -129,6 +151,12 @@
:styleDialogStatus="styleDialogStatus"
></StyleDialog>
</span>
<documentation-dialog
:color="appColor.primary"
:visible="showDocumentationDialog"
:item="selectedDocumentationLayer"
@close="showDocumentationDialog = false"
></documentation-dialog>
<span v-if="timePickerDialogStatus">
<TimePicker
:status="timePickerDialogStatus"
Expand All @@ -152,12 +180,14 @@ import TimePicker from "./TimePicker.vue";
import InLegend from "../viewer/ol/controls/InLegend.vue";
import ApiService from "../../services/api.service";
import { GET_USER_CUSTOM_DATA } from "../../store/actions.type";
import DocumentationDialog from "../other/DocumentationDialog.vue";
export default {
mixins: [Mapable, Legend, LayerTree],
components: {
InLegend,
StyleDialog,
TimePicker
TimePicker,
DocumentationDialog
},
data: () => ({
indicatorLayers: [],
Expand All @@ -174,7 +204,9 @@ export default {
currentItem: null,
styleDialogKey: 0,
styleDialogStatus: false,
timePickerDialogStatus: false
timePickerDialogStatus: false,
showDocumentationDialog: false,
selectedDocumentationLayer: null
}),
mounted() {
EventBus.$on("updateStyleDialogStatusForLayerOrder", value => {
Expand Down Expand Up @@ -391,6 +423,10 @@ export default {
} else {
return false;
}
},
openDocumentation(layer) {
this.showDocumentationDialog = true;
this.selectedDocumentationLayer = layer;
}
},
watch: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,8 @@ export default {
pois: amenity ? this.$t(`pois.${amenity}`) : amenity
};
let value = numberSeparator(
this.getString(parseInt(sumPois[amenity]))
this.getString(parseInt(sumPois[amenity])),
this.$i18n.locale
);
obj[`isochrone-${calculation.id}`] = value || "-";
if (poisObj[amenity]) {
Expand Down
16 changes: 14 additions & 2 deletions app/client/src/components/other/DocumentationDialog.vue
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
<iframe
@load="isLoading = false"
scrolling="yes"
:src="item.mapLayer.get('docUrl')"
:src="getDocUrl"
>
</iframe></div
></vue-scroll>
Expand Down Expand Up @@ -62,12 +62,23 @@ export default {
this.$emit("close");
}
}
},
getDocUrl() {
//DE: plan4better.de/docs/heatmap-connectivity
//EN: plan4better.de/en/docs/heatmap-connectivity
let docUrl = this.item.get("docUrl");
if (docUrl.includes("/en/docs") && this.$i18n.locale === "de") {
docUrl = docUrl.replace("/en/docs", "/docs");
} else if (!docUrl.includes("/en/docs") && this.$i18n.locale === "en") {
docUrl = docUrl.replace("/docs", "/en/docs");
}
return docUrl;
}
},
methods: {
openDocInNetTab() {
if (!this.item) return;
const url = this.item.mapLayer.get("docUrl");
const url = this.getDocUrl;
if (url) {
window.open(url, "_blank");
}
Expand All @@ -83,6 +94,7 @@ export default {
overflow: hidden;
margin: 15px auto;
max-width: 800px;
height: 530px;
}

iframe {
Expand Down
3 changes: 2 additions & 1 deletion app/client/src/factory/layer.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ export const LayerFactory = {
layerOrderKey: 1,
queryable: lConf.queryable,
displayInLayerList: lConf.display_in_layer_list || true,
legendGraphicUrls: lConf.legend_urls || null
legendGraphicUrls: lConf.legend_urls || null,
docUrl: lConf.doc_url || null
};
if (lConf.min_resolution) {
lOpts.minResolution = lConf.min_resolution;
Expand Down