-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate env variables #1851
Separate env variables #1851
Conversation
Copied from walking-matrix branch
+ set uvicorn port according to env file - Add API_PORT to .env file
for filename in *.py; do | ||
if grep -q '# TODO:' $filename; | ||
then | ||
echo "### $filename" | ||
sed -n -e '/^# TODO:/p' $filename| sed -e "s/^# TODO://" | sed 's/.*/- [ ]&/' | ||
fi | ||
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might not need this. We can use this plugin:
https://marketplace.visualstudio.com/items?itemName=wayou.vscode-todo-highlight
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not highlighter. It lists the TODOs for github issue. The code highlighters already highlight TODOs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okey, so you are opening an issue for the TODOs? When is this called ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the last commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get it. So you are exporting to copy it when creating the epic issues (markdown). The highlight plugin also can export but not sure if markdown.
Anyways, maybe we can extend this also for the front end, as now this works only for the python files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is for separating env variables of docker-compose and uvicorn Ports. In related issues there are more details.
Relate issue: #1830 #1831