Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate env variables #1851

Merged
merged 3 commits into from
Jan 6, 2023

Conversation

metemaddar
Copy link
Contributor

@metemaddar metemaddar commented Jan 5, 2023

Relate issue: #1830 #1831

Copied from walking-matrix branch
+ set uvicorn port according to env file
  - Add API_PORT to .env file
@metemaddar metemaddar requested a review from majkshkurti January 5, 2023 15:27
Comment on lines +1 to +7
for filename in *.py; do
if grep -q '# TODO:' $filename;
then
echo "### $filename"
sed -n -e '/^# TODO:/p' $filename| sed -e "s/^# TODO://" | sed 's/.*/- [ ]&/'
fi
done
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not highlighter. It lists the TODOs for github issue. The code highlighters already highlight TODOs.

Copy link
Member

@majkshkurti majkshkurti Jan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey, so you are opening an issue for the TODOs? When is this called ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the last commit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get it. So you are exporting to copy it when creating the epic issues (markdown). The highlight plugin also can export but not sure if markdown.
Anyways, maybe we can extend this also for the front end, as now this works only for the python files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is for separating env variables of docker-compose and uvicorn Ports. In related issues there are more details.

@majkshkurti majkshkurti merged commit 62d8cd9 into goat-community:dev Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants