feat: A new way to deal with the POIs #2033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We structured the POIs in a better way. We avoided adding them to the layer, so we just saved them in the vuex state. The application is much faster now.
I also implemented a formula to calculate the right max zoom level where the POIs start to show up:
log2(P / (W / 2000))
P: The count of the POIs and AOIs
W: The width of the map in pixels
Note!!! : please check the data upload. I removed the dispatch because it was freezing my browser and because it would repeat the step of storing the POIs. Maybe we just make a process where we add them and not request them over again.