Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isochrone to celery #2042

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Isochrone to celery #2042

merged 1 commit into from
Jul 5, 2023

Conversation

metemaddar
Copy link
Contributor

@metemaddar metemaddar commented Mar 20, 2023 •
edited
Loading

Changes

  • Changed crud_isochrone.calculate() result from Response to byte
  • Extracted study_area_bounds from crud_isochrone.calculate() out, as it was async. So it is fetched at endpoint.
  • The result of calculate() is converted to hex string first and then saved to REDIS and converted back at results endpoint.

Related issue:

@metemaddar metemaddar marked this pull request as draft March 20, 2023 08:28
majkshkurti
majkshkurti reviewed Mar 27, 2023
View reviewed changes
Copy link
Member

@majkshkurti majkshkurti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Mohammad. I will test this in the following days and also change the client.

@metemaddar
Copy link
Contributor Author

Conflicts are resolved, but I'm moving the changes to new files indicators.py.

@metemaddar metemaddar changed the base branch from dev to feature/isochrone-celery April 14, 2023 14:48
@metemaddar
Copy link
Contributor Author

test for isochrone wheelchair mode was removed

@metemaddar metemaddar marked this pull request as ready for review May 11, 2023 04:42
@metemaddar
Copy link
Contributor Author

fixed validation for multi starting point isochrone a929d07

@EPajares EPajares changed the base branch from feature/isochrone-celery to dev July 5, 2023 06:57
@EPajares EPajares merged commit f329349 into goat-community:dev Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majkshkurti majkshkurti majkshkurti left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@metemaddar @majkshkurti @EPajares