Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST] for Heatmaps & Customizations 🧪 #2092

Merged
merged 7 commits into from
Apr 14, 2023
Merged

[TEST] for Heatmaps & Customizations 🧪 #2092

merged 7 commits into from
Apr 14, 2023

Conversation

metemaddar
Copy link
Contributor

@metemaddar metemaddar commented Mar 28, 2023 •
edited
Loading

  • 2 Examples Failed ✖️
  • 1 Time outed ⌛
  • 9 Passed ✔️

Related issues:

@metemaddar metemaddar changed the title [TEST] for heatmaps 🧪 [TEST] for Heatmaps & Customizations 🧪 Apr 5, 2023
@metemaddar
Copy link
Contributor Author

Added tests for customizations.

The following tests are failing ✖️

  • test_superuser_get_normal_user_setting
    • Test for existence of poi_groups fails
  • test_superuser_delete_normal_user_setting
    • Faces bad request

@metemaddar
Copy link
Contributor Author

@cinaaaa
The following API address will change. It seems only used at dashboard. It had a typo that didn't have slash before user_id:

  • /api /v1 /customizations /{user_id} /{study_area_id}

@metemaddar
Copy link
Contributor Author

@cinaaaa
@majkshkurti

It will raise 403 for dashboard when expected superuser, but normal user is logged in. Previously we used 400.

@majkshkurti majkshkurti marked this pull request as ready for review April 14, 2023 11:21
@majkshkurti majkshkurti merged commit fe6d6e2 into goat-community:dev Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majkshkurti majkshkurti majkshkurti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metemaddar @majkshkurti