Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Bleatbot #41

Merged
merged 5 commits into from
Aug 21, 2022
Merged

WIP: Bleatbot #41

merged 5 commits into from
Aug 21, 2022

Conversation

NotNite
Copy link
Contributor

@NotNite NotNite commented Jun 11, 2022

From #37, I present to you: Bleatbot!

Our very own beepy-boopy GitHub bot. See the (very lazily written) DIP for info.

I expect to revise the DIP in a bit, feel free to comment if I was too lazy at points. Also I stole a bunch of text from DIP29.

text/41-bleatbot.md Outdated Show resolved Hide resolved
@philpax
Copy link
Contributor

philpax commented Jun 18, 2022

Sorry, should've gotten back to you earlier. This seems pretty reasonable to me - might be nice to get opinions from other members of @goatcorp/community-moderation to see if they have any needs they think should be addressed.

@NotNite
Copy link
Contributor Author

NotNite commented Jun 18, 2022

I ask of someone to invite the bot to the GitHub organization so I can check who can use it based on if they're in the organization.

@philpax
Copy link
Contributor

philpax commented Jun 18, 2022

I've taken the liberty of inviting bleatbot. pls don't aboos api access

This also looks good for inspiration on automating the DIPs if we want to: https://github.com/rust-lang/rfcbot-rs. Here's a good example of it in use: rust-lang/rust#94119

@NotNite
Copy link
Contributor Author

NotNite commented Jun 18, 2022

Maybe I'll clean up my profanity in the Git history and we can make a goatcorp/bleatbot repo so other people can help contribute. I'm a bit bad at writing good code... lol

@NotNite
Copy link
Contributor Author

NotNite commented Jun 19, 2022

I ask of someone to invite the bot to the GitHub organization so I can check who can use it based on if they're in the organization.

Implemented this. My Git history is a bit messy so I'm definitely going to wipe it when I publish it, but it should be not-awful-enough to go on goatcorp/bleatbot if we're okay with making it.

@philpax
Copy link
Contributor

philpax commented Aug 19, 2022

@bleatbot exists but doesn't implement this DIP, afaik. Do we close this?

@NotNite
Copy link
Contributor Author

NotNite commented Aug 19, 2022

No. It implements this DIP. I am waiting on goat's approval to move to its own repository under goatcorp/.

@philpax
Copy link
Contributor

philpax commented Aug 19, 2022

What's doing the bleatbot, approve stuff then?

@NotNite
Copy link
Contributor Author

NotNite commented Aug 19, 2022

I believe a serverless function? It should ideally be moved to bleatbot's TS codebase in the future.

@philpax
Copy link
Contributor

philpax commented Aug 19, 2022

@goaaats can you provide some clarity around what @bleatbot is doing/running and where the code for that lives? Once that's clarified we'll unify that with the bleatbot codebase, update this DIP, merge it in, and bring bleatbot into the corp

@goaaats
Copy link
Member

goaaats commented Aug 19, 2022

The only thing I run atm re: bleatbot is a CF worker that dispatches builds for plogon, here's the code(has CD set up): https://github.com/goatcorp/worker-plugindispatch/actions

@philpax
Copy link
Contributor

philpax commented Aug 21, 2022

@NotNite do you think it'd be possible to integrate that dispatcher into your code? Does it need to be integrated?

@NotNite
Copy link
Contributor Author

NotNite commented Aug 21, 2022

I'm not sure if it needs to be integrated, but it would probably be easy to pull off. I think the real concern is finding people to help develop Bleatbot as I'm starting school soon.

@philpax
Copy link
Contributor

philpax commented Aug 21, 2022

That's fine, we can just get it up and running and build up new features as required. If we start on #46, deploying bleatbot to somewhere on goatcorp infra should be pretty easy. Given there's no general objection to the concept or implementation, I'm going to merge this and we can work out the specifics of implementation as we go.

@philpax philpax merged commit 011581a into goatcorp:main Aug 21, 2022
@Bluefissure
Copy link

The only thing I run atm re: bleatbot is a CF worker that dispatches builds for plogon, here's the code(has CD set up): https://github.com/goatcorp/worker-plugindispatch/actions

Hi @goaaats and @NotNite, I worked on some of the rebuild functions into bleatbot to trigger the workflow. ottercorp/bleatbot@66469e9

Since I don't have access to the worker-plugindispatch repo I can only guess the behaviour of the command. No cooldown is introduced for now.

If it looks okay I can make a PR to bleatbot, but I think it's better to compare it with worker-plugindispatch first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants