Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title Edit v3.0.3.0 #4778

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Title Edit v3.0.3.0 #4778

merged 1 commit into from
Nov 16, 2024

Conversation

RokasKil
Copy link
Contributor

  • 7.1 and API11 update
  • When using the "Track player location" feature with "Save Eorzea time" unchecked, the plugin will use the current Eorzea time instead of midnight (thanks @Scrxtchy)
  • Added an option to use current Eorzea time instead of a predefined time in presets
  • Rewrote world layout change detection hooking to fix a rare crash

Depends on aers/FFXIVClientStructs#1183 going through, won't work without it

@bleatbot bleatbot enabled auto-merge (squash) November 15, 2024 16:19
@bleatbot
Copy link
Collaborator

bleatbot commented Nov 15, 2024

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

The average merge time for plugin updates is currently 13 hours.

Name Commit Status
TitleEdit [stable] 7ac7f30 Build failed (Diff)
8 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
7 hidden needs (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added the build failed This plugin failed to build. label Nov 15, 2024
@goaaats
Copy link
Member

goaaats commented Nov 15, 2024

bleatbot, rebuild

@bleatbot
Copy link
Collaborator

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ TitleEdit [stable] 7ac7f30 v3.0.3.0 - Diff (303 lines, prev. 3.0.2.3) - Semantic
8 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
7 hidden needs (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added size-small Diff for this PR is small. and removed build failed This plugin failed to build. labels Nov 15, 2024
@reiichi001 reiichi001 added the blocked Blocked on an issue that needs to be resolved before merge label Nov 15, 2024
@reiichi001
Copy link
Contributor

I've added the block label so PAC know to not merge this until the CS update goes through. Alternatively, please mark this as a draft and then switch it back to a normal PR once the dependency update is merged and released.

@RokasKil RokasKil marked this pull request as draft November 15, 2024 20:50
auto-merge was automatically disabled November 15, 2024 20:50

Pull request was converted to draft

@RokasKil
Copy link
Contributor Author

Marked it as a draft

@reiichi001
Copy link
Contributor

reiichi001 commented Nov 15, 2024

I see the CS PR has been merged. If you can confirm that the latest Dalamud release contains the contents and retest the plugin, then I can work on reviewing this and merging it.

@reiichi001 reiichi001 marked this pull request as ready for review November 16, 2024 03:26
@reiichi001 reiichi001 merged commit 982ae18 into goatcorp:main Nov 16, 2024
2 checks passed
@RokasKil RokasKil deleted the TitleEdit branch November 18, 2024 16:37
Felscream pushed a commit to Felscream/DragoonMayCryD17 that referenced this pull request Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked on an issue that needs to be resolved before merge size-small Diff for this PR is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants