Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully serve #15

Merged
merged 3 commits into from
Oct 18, 2015
Merged

Gracefully serve #15

merged 3 commits into from
Oct 18, 2015

Conversation

heavyk
Copy link
Contributor

@heavyk heavyk commented Jul 6, 2015

as mentioned in gobblejs/gobble#84 this is the other half.

notably, I bumped liftoff too, so with this you can close #7

cheers

@heavyk
Copy link
Contributor Author

heavyk commented Jul 21, 2015

hi @Rich-Harris just wondering if this could get merged so I can just tell my workmates to npm install gobble-cli instead of installing both of my branches. it helps a lot for windows machines. sometimes gobble build even fails without these patches

for additional reference to the gracefulify change, npm has implemented this change too. npm/npm#8735

the reason why gobble still spits out errors from time to time, is because although chokidar's fs is patched, a following read or write originating from the original fs module can still produce an error. this gets around the problem by monkey patching the fs module globally

cheers

* master:
  try a different way of error logging
  -> 0.4.3
  Make error message logger more reliable
@Rich-Harris Rich-Harris merged commit 36f1676 into gobblejs:master Oct 18, 2015
@Rich-Harris
Copy link
Contributor

@heavyk Sorry for the epic delay, and thanks for the fix – have released this as 0.6.0

@heavyk
Copy link
Contributor Author

heavyk commented Oct 18, 2015

it's ironic that you merged this the very same day that my workmate converted to ubuntu :)

cheers mate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

liftoff 2x / v8flags 2x released
2 participants