Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nobids/improve ens resolver error handling #2766

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Nobids/improve ens resolver error handling #2766

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
272a7a7
(NOBIDS) Demote "not a resolver" error thrown by validateEnsName to w…
D13ce Dec 12, 2023
6019e9e
(NOBIDS) Merge branch 'master' into NOBIDS/ImproveENSResolverErrorHan…
D13ce Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion db/ens.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,12 @@ func (bigtable *Bigtable) ImportEnsUpdates(client *ethclient.Client) error {
if name != "" {
err := validateEnsName(client, name, &alreadyChecked, nil)
if err != nil {
return fmt.Errorf("error validating new name [%v]: %w", name, err)
if err.Error() == "not a resolver" {
// if resolving the given name results in an address that is not a resolver, we cannot do anything with it and just skip it
logger.Warnf("resolving name [%s] resulted in an address that is not a resolver, skipping it", name)
} else {
return fmt.Errorf("error validating new name [%v]: %w", name, err)
}
}
} else if address != nil {
err := validateEnsAddress(client, *address, &alreadyChecked)
Expand Down
Loading