ws: bring back support for go1.16 #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `go1.16 build .` failed with:
//go:build comment without // +build comment
|
Hi, any reasons to live on 1.16 ? That's an old version. |
|
Hi, |
cristaloleg
approved these changes
May 18, 2023
|
Wow, so quick! Thank you! BTW, I saw the release note for v1.2 states that this package will drop support for go1.16. May I know why? Are you planning to do something new that it's a big burden to support go1.16? |
|
Well, we had a plan to drop support of old versions (there are a few places from what I remember). But after this PR I think we should postpone it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
go1.16 build .failed with:Fixes chromedp/chromedp#1310.