-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #560 & #561 #567
Fix #560 & #561 #567
Conversation
Codecov Report
@@ Coverage Diff @@
## master #567 +/- ##
==========================================
- Coverage 82.67% 82.62% -0.05%
==========================================
Files 53 53
Lines 6995 6999 +4
==========================================
Hits 5783 5783
- Misses 967 969 +2
- Partials 245 247 +2
Continue to review full report at Codecov.
|
#561 still needs fix. The following is an evaluation test for that: func TestEmptyCodeEvaluation(t *testing.T) {
tests := []struct {
input string
expected string
}{
{``, ""},
{`
`, ""},
}
for i, tt := range tests {
v := initTestVM()
evaluated := v.testEval(t, tt.input, getFilename())
if isError(evaluated) {
t.Fatalf("got Error: %s", evaluated.(*Error).message)
}
verifyExpected(t, i, evaluated, tt.expected)
v.checkCFP(t, i, 0)
v.checkSP(t, i, 1)
}
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#561 still needs fix
@hachi8833 I've tried that. We can't test that in current testing approach, because the parser will have different mode and behavior under test environment. And the issue you mentioned is a test-mode-only issue. |
Got it |
@hachi8833 Do you approve this PR? |
This closes #560 and closes #561