Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adding VM Float API #615

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
{
}
129 changes: 129 additions & 0 deletions vm/float.go
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,135 @@ func builtinFloatInstanceMethods() []*BuiltinMethodObject {
}
},
},
{
// Returns the Float as a positive value.
//
// ```Ruby
// -34.56.abs # => 34.56
// 34.56.abs # => 34.56
// ```
// @return [Float]
Name: "abs",
Fn: func(receiver Object, sourceLine int) builtinMethodBody {
return func(t *thread, args []Object, blockFrame *normalCallFrame) Object {
if len(args) != 0 {
return t.vm.initErrorObject(errors.ArgumentError, sourceLine, "Expect 0 argument. got=%v", strconv.Itoa(len(args)))
}
r := receiver.(*FloatObject)
result := math.Abs(r.value)
return t.vm.initFloatObject(result)
}
},
},
{
// Returns the smallest Integer greater than or equal to self.
//
// ```Ruby
// 1.2.ceil # => 2
// 2.ceil # => 2
// -1.2.ceil # => -1
// -2.ceil # => -2
// ```
// @return [Integer]
Name: "ceil",
Fn: func(receiver Object, sourceLine int) builtinMethodBody {
return func(t *thread, args []Object, blockFrame *normalCallFrame) Object {
// TODO: Make ceil accept arguments
if len(args) != 0 {
return t.vm.initErrorObject(errors.ArgumentError, sourceLine, "Expect 0 argument. got=%v", strconv.Itoa(len(args)))
}
r := receiver.(*FloatObject)
result := math.Ceil(r.value)
newInt := t.vm.initIntegerObject(int(result))
newInt.flag = i
return newInt
}
},
},
{
// Returns the largest Integer less than or equal to self.
//
// ```Ruby
// 1.2.floor # => 1
// 2.0.floor # => 2
// -1.2.floor # => -2
// -2.0.floor # => -2
// ```
// @return [Integer]
Name: "floor",
Fn: func(receiver Object, sourceLine int) builtinMethodBody {
return func(t *thread, args []Object, blockFrame *normalCallFrame) Object {
// TODO: Make floor accept arguments
if len(args) != 0 {
return t.vm.initErrorObject(errors.ArgumentError, sourceLine, "Expect 0 argument. got=%v", strconv.Itoa(len(args)))
}
r := receiver.(*FloatObject)
result := math.Floor(r.value)
newInt := t.vm.initIntegerObject(int(result))
newInt.flag = i
return newInt
}
},
},
{
// Returns true if Float is equal to 0.0
//
// ```Ruby
// 0.0.zero? # => true
// 1.0.zero? # => false
// ```
// @return [Boolean]
Name: "zero?",
Fn: func(receiver Object, sourceLine int) builtinMethodBody {
return func(t *thread, args []Object, blockFrame *normalCallFrame) Object {
if len(args) != 0 {
return t.vm.initErrorObject(errors.ArgumentError, sourceLine, "Expect 0 argument. got=%v", strconv.Itoa(len(args)))
}
r := receiver.(*FloatObject)
return toBooleanObject(r.value == 0.0)
}
},
},
{
// Returns true if Float is larger than 0.0
//
// ```Ruby
// -1.0.positive? # => false
// 0.0.positive? # => false
// 1.0.positive? # => true
// ```
// @return [Boolean]
Name: "positive?",
Fn: func(receiver Object, sourceLine int) builtinMethodBody {
return func(t *thread, args []Object, blockFrame *normalCallFrame) Object {
if len(args) != 0 {
return t.vm.initErrorObject(errors.ArgumentError, sourceLine, "Expect 0 argument. got=%v", strconv.Itoa(len(args)))
}
r := receiver.(*FloatObject)
return toBooleanObject(r.value > 0.0)
}
},
},
{
// Returns true if Float is less than 0.0
//
// ```Ruby
// -1.0.negative? # => true
// 0.0.negative? # => false
// 1.0.negative? # => false
// ```
// @return [Boolean]
Name: "negative?",
Fn: func(receiver Object, sourceLine int) builtinMethodBody {
return func(t *thread, args []Object, blockFrame *normalCallFrame) Object {
if len(args) != 0 {
return t.vm.initErrorObject(errors.ArgumentError, sourceLine, "Expect 0 argument. got=%v", strconv.Itoa(len(args)))
}
r := receiver.(*FloatObject)
return toBooleanObject(r.value < 0.0)
}
},
},
}
}

Expand Down
114 changes: 114 additions & 0 deletions vm/float_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -266,3 +266,117 @@ func TestFloatZeroDivisionFail(t *testing.T) {
v.checkSP(t, i, 1)
}
}

func TestFloatAbs(t *testing.T) {
tests := []struct {
input string
expected interface{}
}{
{"34.56.abs", 34.56},
{"-34.56.abs", 34.56},
}

for i, tt := range tests {
v := initTestVM()
evaluated := v.testEval(t, tt.input, getFilename())
verifyExpected(t, i, evaluated, tt.expected)
v.checkCFP(t, i, 0)
v.checkSP(t, i, 1)
}
}

func TestFloatCeil(t *testing.T) {
tests := []struct {
input string
expected interface{}
}{
{"1.2.ceil", 2},
{"2.0.ceil", 2},
{"-1.2.ceil", -1},
{"-2.0.ceil", -2},
}

for i, tt := range tests {
v := initTestVM()
evaluated := v.testEval(t, tt.input, getFilename())
verifyExpected(t, i, evaluated, tt.expected)
v.checkCFP(t, i, 0)
v.checkSP(t, i, 1)
}
}

func TestFloatFloor(t *testing.T) {
tests := []struct {
input string
expected interface{}
}{
{"1.2.floor", 1},
{"2.0.floor", 2},
{"-1.2.floor", -2},
{"-2.0.floor", -2},
}

for i, tt := range tests {
v := initTestVM()
evaluated := v.testEval(t, tt.input, getFilename())
verifyExpected(t, i, evaluated, tt.expected)
v.checkCFP(t, i, 0)
v.checkSP(t, i, 1)
}
}

func TestZero(t *testing.T) {
tests := []struct {
input string
expected interface{}
}{
{"0.0.zero?", true},
{"1.0.zero?", false},
}

for i, tt := range tests {
v := initTestVM()
evaluated := v.testEval(t, tt.input, getFilename())
verifyExpected(t, i, evaluated, tt.expected)
v.checkCFP(t, i, 0)
v.checkSP(t, i, 1)
}
}

func TestPositive(t *testing.T) {
tests := []struct {
input string
expected interface{}
}{
{"-1.0.positive?", false},
{"0.0.positive?", false},
{"1.0.positive?", true},
}

for i, tt := range tests {
v := initTestVM()
evaluated := v.testEval(t, tt.input, getFilename())
verifyExpected(t, i, evaluated, tt.expected)
v.checkCFP(t, i, 0)
v.checkSP(t, i, 1)
}
}

func TestNegative(t *testing.T) {
tests := []struct {
input string
expected interface{}
}{
{"-1.0.negative?", true},
{"0.0.negative?", false},
{"1.0.negative?", false},
}

for i, tt := range tests {
v := initTestVM()
evaluated := v.testEval(t, tt.input, getFilename())
verifyExpected(t, i, evaluated, tt.expected)
v.checkCFP(t, i, 0)
v.checkSP(t, i, 1)
}
}