-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #555 #683
Conversation
Codecov Report
@@ Coverage Diff @@
## master #683 +/- ##
==========================================
+ Coverage 80.24% 80.25% +<.01%
==========================================
Files 54 54
Lines 7402 7403 +1
==========================================
+ Hits 5940 5941 +1
Misses 1237 1237
Partials 225 225
Continue to review full report at Codecov.
|
Sorry for the delay: I'd check this 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for fixing the issue!
I prepared exhaustive tests for the issue, based on the old PR I once made.
And found some errors that need fixes.
How do I send the test to you?
You can leave them in comment or push to the branch |
Pushed the updated branch. |
Just to memorize the additional tests for the PR |
- See #683 - Updated some classes such as null.go, too
@hachi8833 can you give it a quick review and I'll just merge it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I checked with the unary operators +
and -
on the fix, no wrong behavior has been found. Thank you very much!
(I was amazed the fix is very very small😳)
@hachi8833 really? I can't verify that right now, you can close #568 if you feel confident about the fix. I'd say it's ok to close it if we don't see errors from examples on the top description. |
I will verify if #568 is fixed after merging and close it. 👍 |
Strange... this time the issue on #568 still persists😓. Forget it. |
This closes #555