Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding quiz error handling when answering a question or completing quiz #2595

Merged
merged 8 commits into from
Feb 14, 2024

Conversation

brianhogg
Copy link
Contributor

@brianhogg brianhogg commented Feb 12, 2024

Description

Fixes #2594

How has this been tested?

Manually by turning off the database temporarily

Screenshots

Quiz.Internet.Drop.Error.Handling.mp4

Types of changes

Error handling when answering a question or submitting a quiz.

Checklist:

  • This PR requires and contains at least one changelog file.
  • My code has been tested.
  • My code passes all existing automated tests.
  • My code follows the LifterLMS Coding & Documentation Standards.

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 77.18% 328/425
🟡 Branches 68.45% 141/206
🟢 Functions 82.93% 68/82
🟡 Lines 76.68% 319/416

Test suite run success

169 tests passing in 22 suites.

Report generated by 🧪jest coverage report action from af7d3f4

@brianhogg brianhogg changed the base branch from trunk to dev February 12, 2024 02:45
assets/js/llms-quiz.js Show resolved Hide resolved
@@ -279,6 +284,12 @@

}

},

error: function ( jqXHR, status, error ) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identical blocks of code found in 2 locations. Consider refactoring.

Copy link

codeclimate bot commented Feb 12, 2024

Code Climate has analyzed commit af7d3f4 and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2
Duplication 2

The test coverage on the diff in this pull request is 2.8% (50% is the threshold).

This pull request will bring the total coverage in the repository to 56.3%.

View more on Code Climate.

@brianhogg brianhogg marked this pull request as ready for review February 14, 2024 13:55
@brianhogg brianhogg requested a review from ideadude as a code owner February 14, 2024 13:55
@ideadude ideadude merged commit f576597 into dev Feb 14, 2024
28 checks passed
@ideadude ideadude deleted the fix/quiz-error-handling-answering-question branch February 14, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

No error handling when taking a quiz
2 participants