Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove codeclimate #2596

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Remove codeclimate #2596

merged 1 commit into from
Feb 13, 2024

Conversation

brianhogg
Copy link
Contributor

Description

Remove codeclimate

Checklist:

  • This PR requires and contains at least one changelog file.
  • My code has been tested.
  • My code passes all existing automated tests.
  • My code follows the LifterLMS Coding & Documentation Standards.

@brianhogg brianhogg requested a review from ideadude as a code owner February 12, 2024 16:07
@ideadude
Copy link
Member

The top comment in there says:

This workflow file is deployed into this repository via the "Sync Organization Files" workflow

I couldn't find that Sync Organization Files workflow, but will keep an eye out to see if this file creeps back or something.

@ideadude
Copy link
Member

I think we'd also like to remove any reference to these checks in the various docs. Search the repo for "codeclimate".

@ideadude ideadude merged commit 84fd15b into dev Feb 13, 2024
38 checks passed
@ideadude ideadude deleted the fix/remove-codeclimate branch February 13, 2024 19:38
@eri-trabiccolo
Copy link
Collaborator

Hey people,
you can remove the file here:
https://github.com/gocodebox/.github/blob/trunk/.github/workflow-templates/php-test-coverage.yml

and the references here :
https://github.com/gocodebox/.github/blob/trunk/.github/workflows/workflow-sync.yml#L17
https://github.com/gocodebox/.github/blob/trunk/.github/workflows/workflow-sync.yml#L58

on the latter you can also see to what repository has been added btw, I think should be then manually removed from them too. <3

@brianhogg
Copy link
Contributor Author

Thanks @eri-trabiccolo ! Those changes have been made :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants