Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing flaky award task test #2598

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Removing flaky award task test #2598

merged 2 commits into from
Feb 14, 2024

Conversation

brianhogg
Copy link
Contributor

Description

A test is randomly failing. Marking the test as skipped for now until we investigate and fix or rewrite.

Checklist:

  • This PR requires and contains at least one changelog file.
  • My code has been tested.
  • My code passes all existing automated tests.
  • My code follows the LifterLMS Coding & Documentation Standards.

1) LLMS_Test_Processor_Awarded_Certificates_Bulk_Sync::test_task
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => 'an error occurred while trying to sync awarded certificate A certificate title (#1714) from template Post title 0078916 (#1712)'
-    1 => 'awarded certificate Post title 0078917 (#1713) successfully synced with template Post title 0078916 (#1712)'
+    0 => 'an error occurred while trying to sync awarded certificate Post title 0078917 (#1713) from template Post title 0078916 (#1712)'
+    1 => 'awarded certificate A certificate title (#1714) successfully synced with template Post title 0078916 (#1712)'
     2 => 'awarded certificate bulk sync...#1712)'
     3 => 'awarded certificates bulk syn...hunk 1'
 )

/home/runner/work/lifterlms/lifterlms/tmp/tests/wordpress-tests-lib/includes/abstract-testcase.php:980
/home/runner/work/lifterlms/lifterlms/tests/phpunit/unit-tests/processors/class-llms-test-processor-awarded-certificates-bulk-sync.php:387
@brianhogg brianhogg requested a review from ideadude as a code owner February 14, 2024 11:38
@brianhogg brianhogg changed the base branch from trunk to dev February 14, 2024 11:38
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 77.18% 328/425
🟡 Branches 68.45% 141/206
🟢 Functions 82.93% 68/82
🟡 Lines 76.68% 319/416

Test suite run success

169 tests passing in 22 suites.

Report generated by 🧪jest coverage report action from df2d863

Copy link

codeclimate bot commented Feb 14, 2024

Code Climate has analyzed commit df2d863 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 2.8% (50% is the threshold).

This pull request will bring the total coverage in the repository to 56.2%.

View more on Code Climate.

@ideadude ideadude merged commit 62fcb80 into dev Feb 14, 2024
32 checks passed
@ideadude ideadude deleted the fix/flaky-test-and-codeclimate branch February 14, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants