Change editor asset from init to enqueue_block_editor_assets #2243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanbardo
requested review from
AnthonyLedesma,
EvanHerman,
jrtashjian and
olafleur-godaddy
as code owners
|
Download coblocks.zip: https://41921-128991767-gh.circle-artifacts.com/0/tmp/artifacts/coblocks-2243.zip |
AnthonyLedesma
approved these changes
Jan 26, 2022
|
@AnthonyLedesma actually this is breaking the Editor Settings somehow. I need to look into that further. |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
jasonlemay
pushed a commit
that referenced
this pull request
Jan 28, 2022
* Change editor asset from init to enqueue_block_editor_assets * Use previous func name * Change hook on settings panel class too Co-authored-by: Jonathan Bardo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move from init to enqueue_block_editor_assets to enqueue our scripts.